Fix sub dirs #415
Fix sub dirs #415
Conversation
TL;DR: We were vendoring too much, this should fix that w/o breaking anything (tm). While working with an internal project and a bunch of go1.6 repos I observed `go install ./...` trying to compile stuff that is in the vendor directory, but doesn't have all of the deps also vendored. This means that they were being copied in incorrectly. Upon inspection of the code I noticed that vcs files would list all files and the sub directories and the dependency checks in fill would skip packages based on import prefix, when (AFAICT) it should only skip standard and the primary root package importPath. I also discovered a few tests that appear to be faulty, or exhibit older behaviour that I never reviewed. Basically this commit makes it so that when filling godeps we include all dependencies and when saving we don't automatically process sub directories of packages unless those sub-directories are also packages that are required by the dependency search. This commit adjusts some tests which I hand validated for behaviour. Most tests though are unchanged. Also added positional identifier for more save test errors. More debug added for later operations of save/update.
|
I assume this hasn't been merged, correct? |
|
👍 I'm running into this issue as well! |
|
Also note that this patch "increases" the number of listed dependencies because we're no longer doing the path prefix match in godep fill. Previously if you had something like: You would get a dependency on Now you get both dependencies recorded ( |
|
This was okay in the "workspace" days because of the rewrites or requirement to prefix |
TL;DR: We were vendoring too much, this should fix that w/o breaking
anything (tm).
While working with an internal project and a bunch of go1.6 repos I
observed
go install ./...trying to compile stuff that is in thevendor directory, but doesn't have all of the deps also vendored. This
means that they were being copied in incorrectly.
Upon inspection of the code I noticed that vcs files would list all
files and the sub directories and the dependency checks in fill would
skip packages based on import prefix, when (AFAICT) it should only skip
standard and the primary root package importPath.
I also discovered a few tests that appear to be faulty, or exhibit older
behaviour that I didn't even think existed.
Basically this commit makes it so that when filling godeps we include
all dependencies and when saving we don't automatically process sub
directories of packages unless those sub-directories are also packages
that are required by the dependency search.
This commit adjusts some tests which I hand validated for behavior.
Most tests though are unchanged. Also added positional identifier for
more save test errors.
More debug added for later operations of save/update.